factor out google analytics ids (LMS-2555) #3490
Conversation
|
👍 |
| @@ -397,3 +397,7 @@ | |||
|
|
|||
| ##### ADVANCED_SECURITY_CONFIG ##### | |||
| ADVANCED_SECURITY_CONFIG = ENV_TOKENS.get('ADVANCED_SECURITY_CONFIG', {}) | |||
|
|
|||
| ##### GOOGLE ANALYTICS IDS ##### | |||
| GOOGLE_ANALYTICS_MAIN = ENV_TOKENS.get('GOOGLE_ANALYTICS_MAIN') | |||
There was a problem hiding this comment.
Let's move this to AUTH_TOKENS
|
Does this include updating from what is in the public domain or is that an additional step. |
|
@e0d , what do you mean by that? |
|
There are two token dicts, one loaded from, say, lms.env.json, one from lms.auth.json. That latter is used for keys, etc. |
|
@e0d , yeah I changed that already--I was wondering what you meant about the public domain. Like cleaning up our git history? |
|
No, meaning are the keys referenced in the Jira item new or the ones that are already in git history? |
|
Also, do use GA for the the cms? |
|
@e0d , the keys referenced in JIRA are the ones in the git history. Changing those would be an additional step. As far as I can tell, no. |
|
👍 |
|
LGTM 🚀 |
@rocha
@feanil , this requires a change to our servers before we merge this